Skip to content

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 6, 2023

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. typings labels Mar 6, 2023
Copy link
Member

@MoLow MoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 6, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 6, 2023
@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 7, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 8, 2023
@nodejs-github-bot nodejs-github-bot merged commit 0c46051 into nodejs:main Mar 8, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 0c46051

@aduh95 aduh95 deleted the primordials-typings branch March 8, 2023 10:49
targos pushed a commit that referenced this pull request Mar 13, 2023
PR-URL: #46970
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
targos pushed a commit that referenced this pull request Mar 14, 2023
PR-URL: #46970
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
PR-URL: #46970
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. typings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants