test: simplify test-tls-ecdh-multiple #46963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tniessen
added
tls
nodejs-github-bot
added
needs-ci
github-actions
bot
removed
the
request-ci
lpinca
approved these changes
Mar 5, 2023
tniessen
added
the
author ready
anonrig
approved these changes
Mar 6, 2023
VoltrexKeyva
approved these changes
Mar 6, 2023
This was referenced Mar 7, 2023
Avoid the process 'exit' event handler and use execFile instead of manual stream operations. Refs: nodejs#46751 PR-URL: nodejs#46963 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
tniessen
force-pushed
the
test-tls-ecdh-multiple-refactor
branch
from
520205b to
bcebb91
Compare
|
Landed in bcebb91. |
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
Avoid the process 'exit' event handler and use execFile instead of manual stream operations. Refs: #46751 PR-URL: #46963 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
targos
pushed a commit
that referenced
this pull request
Mar 14, 2023
Avoid the process 'exit' event handler and use execFile instead of manual stream operations. Refs: #46751 PR-URL: #46963 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
Avoid the process 'exit' event handler and use execFile instead of manual stream operations. Refs: #46751 PR-URL: #46963 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid the process
'exit'event handler and useexecFileinstead of manual stream operations.Refs: #46751