Skip to content

Conversation

panva
Copy link
Member

@panva panva commented Dec 11, 2022

--experimental-global-webcrypto is no longer needed to execute these tests

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Dec 11, 2022
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 11, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 11, 2022
@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 11, 2022
@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 11, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 13, 2022
@nodejs-github-bot nodejs-github-bot merged commit f9e3c1b into nodejs:main Dec 13, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in f9e3c1b

@panva panva deleted the no-test-webcrypto-flag branch December 13, 2022 11:05
targos pushed a commit that referenced this pull request Jan 1, 2023
PR-URL: #45816
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants