src: remove unnecessary cast in crypto_sig.cc #44001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ByteSource::Allocated accepts a void pointer now, so we do not need to cast the argument to a char pointer. Refs: nodejs#43202
tniessen
added
c++
|
Review requested:
|
|
Fast-track has been requested by @tniessen. Please 👍 to approve. |
nodejs-github-bot
added
crypto
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
panva
approved these changes
Jul 26, 2022
16 tasks
RaisinTen
approved these changes
Jul 27, 2022
F3n67u
approved these changes
Jul 27, 2022
F3n67u
added
author ready
|
@F3n67u did you mean to apply |
@RaisinTen sorry. I don't see there is already a ci run |
panva
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in abddacb |
This was referenced Aug 1, 2022
danielleadams
pushed a commit
that referenced
this pull request
Aug 16, 2022
ByteSource::Allocated accepts a void pointer now, so we do not need to cast the argument to a char pointer. Refs: #43202 PR-URL: #44001 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Feng Yu <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
Aug 23, 2022
ByteSource::Allocated accepts a void pointer now, so we do not need to cast the argument to a char pointer. Refs: #43202 PR-URL: #44001 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Feng Yu <[email protected]>
Fyko
pushed a commit
to Fyko/node
that referenced
this pull request
Sep 15, 2022
ByteSource::Allocated accepts a void pointer now, so we do not need to cast the argument to a char pointer. Refs: nodejs#43202 PR-URL: nodejs#44001 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Feng Yu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ByteSource::Allocatedaccepts avoidpointer now, so we do not need to cast the argument to acharpointer.Refs: #43202