assert: change callTracker.calls signature to use an object param instead of positional arguments

[ErickWendel]

it changes the calls function from the callTracker API, its docs, and tests that use this module. This is a breaking change as the calls function was changed

Refs: #43161

[Trott]

Can you change the subsystem in the first line of the commit message from test: to assert:?

[Trott]

@nodejs/assert

[ErickWendel]

assert

uh! done!

[tniessen]

This is an unnecessary breaking change. The old signature should keep working, or must be deprecated first.

None of the existing tests should need to be modified.

[ErickWendel]

We discussed it here #43161 as the old signature is a bit confusing I thought it'd be better change from positional to object arguments.

This is my first time working on an experimental feature so I thought everything should be moved to the new signature. Even for experimental features we should keep the old tests?

Do you have an example of how to deprecate the old signature? I haven't seen people deprecating functions from experimental features so I'm a bit lost on it haha

[tniessen]

My bad, I forgot that CallTracker is still experimental. Still, it's been around since Node.js 12, and there is no reason to break every application that's using it.

I would maintain both signatures for now and then maybe deprecate the old signature at some point.

With that being said, unless we have specific options that we want to add later, I am not sure if this an improvement.

[ErickWendel]

Uh nice! Do you think it’s still valid to ads this change?

[benjamingr]

Hey @ErickWendel let me know if you want feedback/help with this when you're here for NodeTLV.

In general I think what Tobias suggested is good basically:

• Add the new call signature, deprecate the old call signature (I'm fine with showing a runtime deprecation warning when using it and skipping docs-only because it's experimental).
• In a future semver-major PR, remove the old signature

[ErickWendel]

Hey @ErickWendel let me know if you want feedback/help with this when you're here for NodeTLV.

In general I think what Tobias suggested is good basically:

• Add the new call signature, deprecate the old call signature (I'm fine with showing a runtime deprecation warning when using it and skipping docs-only because it's experimental).
• In a future semver-major PR, remove the old signature

Suure thank you!! I’ll try doing it by the next week. 🤩🤩