Skip to content

stream: fix non readable Duplex readableAborted #40801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

stream: fix non readable Duplex readableAborted #40801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c06554
stream: fix non readable Duplex readableAborted
ronag Nov 13, 2021
6507422
fixup
ronag Nov 13, 2021
e2f4123
fixup
ronag Nov 13, 2021
2f814b8
fixup
ronag Nov 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/internal/streams/readable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1187,8 +1187,11 @@ ObjectDefineProperties(Readable.prototype, {
readableAborted: {
enumerable: false,
get: function() {
return !!(this._readableState.destroyed || this._readableState.errored) &&
!this._readableState.endEmitted;
return !!(
this._readableState.readable !== false &&
(this._readableState.destroyed || this._readableState.errored) &&
!this._readableState.endEmitted
);
}
},

Expand Down
11 changes: 10 additions & 1 deletion test/parallel/test-stream-readable-aborted.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

const common = require('../common');
const assert = require('assert');
const { Readable } = require('stream');
const { Readable, Duplex } = require('stream');

{
const readable = new Readable({
Expand Down Expand Up @@ -55,3 +55,12 @@ const { Readable } = require('stream');
}));
readable.resume();
}

{
const duplex = new Duplex({
readable: false,
write() {}
});
duplex.destroy();
assert.strictEqual(duplex.readableAborted, false);
}