Skip to content

src: make LoadEnvironment with string work with builtin modules path #40607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

src: make LoadEnvironment with string work with builtin modules path #40607

wants to merge 3 commits into from

Conversation

targos
Copy link
Member

@targos targos commented Oct 26, 2021

  • src: make LoadEnvironment with string work with builtin modules path
  • test: skip macos sandbox test with builtin modules path

@targos targos mentioned this pull request Oct 26, 2021
Closed
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Oct 26, 2021
@targos
Copy link
Member Author

targos commented Oct 26, 2021

I know that the commit messages are too long but I couldn't find a more concise wording.

VoltrexKeyva
VoltrexKeyva reviewed Oct 26, 2021
View reviewed changes
@VoltrexKeyva VoltrexKeyva changed the title src: make LoadEnvironment with string work with builtin modules pat src: make LoadEnvironment with string work with builtin modules path Oct 26, 2021
@RaisinTen RaisinTen requested a review from devsnek October 26, 2021 14:06
@GeoffreyBooth
Copy link
Member

Ping @devsnek

@targos
Copy link
Member Author

targos commented Nov 2, 2021

/cc @addaleax

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 2, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 2, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
This was referenced Nov 3, 2021
Open
Open
@nodejs-github-bot

This comment has been minimized.

Sign in to view
This was referenced Nov 5, 2021
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40738/

@github-actions github-actions bot mentioned this pull request Nov 7, 2021
Open
46 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40749/

@targos targos self-assigned this Nov 7, 2021
@github-actions github-actions bot mentioned this pull request Nov 8, 2021
Open
46 tasks
@targos
Copy link
Member Author

targos commented Nov 8, 2021

Landed in 8731193...d0a41c9

@targos targos closed this Nov 8, 2021
targos added a commit that referenced this pull request Nov 8, 2021
@targos
src: make LoadEnvironment with string work with builtin modules path
8c28aaa 
Fixes: #40605

PR-URL: #40607
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
targos added a commit that referenced this pull request Nov 8, 2021
@targos
test: skip macos sandbox test with builtin modules path
d0a41c9 
Refs: #40605

PR-URL: #40607
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos deleted the fix-40605 branch November 8, 2021 07:44
targos added a commit that referenced this pull request Nov 8, 2021
@targos
src: make LoadEnvironment with string work with builtin modules path
fb7c437 
Fixes: #40605

PR-URL: #40607
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
targos added a commit that referenced this pull request Nov 8, 2021
@targos
test: skip macos sandbox test with builtin modules path
8c103ab 
Refs: #40605

PR-URL: #40607
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos mentioned this pull request Nov 8, 2021
Merged
This was referenced Nov 9, 2021
Open
Open
@GeoffreyBooth
Copy link
Member

I can confirm this fixes #40605. Thanks @targos !

@github-actions github-actions bot mentioned this pull request Nov 11, 2021
Open
31 tasks
BethGriggs pushed a commit that referenced this pull request Nov 25, 2021
@targos @BethGriggs
src: make LoadEnvironment with string work with builtin modules path
bc0eb0a 
Fixes: #40605

PR-URL: #40607
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
BethGriggs pushed a commit that referenced this pull request Nov 25, 2021
@targos @BethGriggs
test: skip macos sandbox test with builtin modules path
63b44fc 
Refs: #40605

PR-URL: #40607
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva left review comments

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

@addaleax addaleax addaleax approved these changes

@devsnek devsnek Awaiting requested review from devsnek

Assignees

@targos targos

Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@targos @GeoffreyBooth @nodejs-github-bot @addaleax @VoltrexKeyva