src: use HandleScope in StreamReq::Done() #38720
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
May 18, 2021
This comment has been minimized.
This comment has been minimized.
Ayase-252
reviewed
May 18, 2021
Co-authored-by: Qingyu Deng <[email protected]>
This comment has been minimized.
This comment has been minimized.
addaleax
approved these changes
May 18, 2021
This comment has been minimized.
This comment has been minimized.
RaisinTen
added
the
author ready
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Landed in fcdb1db |
jasnell
pushed a commit
that referenced
this pull request
May 21, 2021
Fixes: #38707 PR-URL: #38720 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
May 31, 2021
Fixes: #38707 PR-URL: #38720 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
richardlau
pushed a commit
that referenced
this pull request
Jul 16, 2021
Fixes: #38707 PR-URL: #38720 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Jul 19, 2021
Fixes: #38707 PR-URL: #38720 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Jul 20, 2021
Fixes: #38707 PR-URL: #38720 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
foxxyz
pushed a commit
to foxxyz/node
that referenced
this pull request
Oct 18, 2021
Fixes: nodejs#38707 PR-URL: nodejs#38720 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #38707