Skip to content

src: remove KeyObjectData::CreateSecret overload #38067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Trott merged 1 commit into from
Apr 6, 2021
Merged

src: remove KeyObjectData::CreateSecret overload #38067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/crypto/crypto_keys.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -837,11 +837,6 @@ void KeyObjectData::MemoryInfo(MemoryTracker* tracker) const {
}
}

std::shared_ptr<KeyObjectData> KeyObjectData::CreateSecret(
const ArrayBufferOrViewContents<char>& buf) {
return CreateSecret(buf.ToCopy());
}

std::shared_ptr<KeyObjectData> KeyObjectData::CreateSecret(ByteSource key) {
CHECK(key);
return std::shared_ptr<KeyObjectData>(new KeyObjectData(std::move(key)));
Expand Down
3 changes: 0 additions & 3 deletions src/crypto/crypto_keys.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,6 @@ class ManagedEVPPKey : public MemoryRetainer {
// Objects of this class can safely be shared among threads.
class KeyObjectData : public MemoryRetainer {
public:
static std::shared_ptr<KeyObjectData> CreateSecret(
const ArrayBufferOrViewContents<char>& buf);

static std::shared_ptr<KeyObjectData> CreateSecret(ByteSource key);

static std::shared_ptr<KeyObjectData> CreateAsymmetric(
Expand Down