Skip to content

test: add OpenSSL 3.0 checks #37860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

test: add OpenSSL 3.0 checks #37860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b6adb5
test: add OpenSSL 3.0 checks to test-crypto-keygen
danbev Mar 22, 2021
a00d23c
test: add OpenSSL 3.0 checks to tls-passphrase
danbev Mar 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/parallel/test-crypto-keygen.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,20 +389,20 @@ const sec1EncExp = (cipher) => getRegExpForPEM('EC PRIVATE KEY', cipher);
{
// Test async DSA key object generation.
generateKeyPair('dsa', {
modulusLength: 512,
modulusLength: common.hasOpenSSL3 ? 2048 : 512,
divisorLength: 256
}, common.mustSucceed((publicKey, privateKey) => {
assert.strictEqual(publicKey.type, 'public');
assert.strictEqual(publicKey.asymmetricKeyType, 'dsa');
assert.deepStrictEqual(publicKey.asymmetricKeyDetails, {
modulusLength: 512,
modulusLength: common.hasOpenSSL3 ? 2048 : 512,
divisorLength: 256
});

assert.strictEqual(privateKey.type, 'private');
assert.strictEqual(privateKey.asymmetricKeyType, 'dsa');
assert.deepStrictEqual(privateKey.asymmetricKeyDetails, {
modulusLength: 512,
modulusLength: common.hasOpenSSL3 ? 2048 : 512,
divisorLength: 256
});
}));
Expand Down
5 changes: 3 additions & 2 deletions test/parallel/test-tls-passphrase.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ server.listen(0, common.mustCall(function() {
})).unref();

const errMessagePassword = common.hasOpenSSL3 ?
/processing error/ : /bad decrypt/;
/Error: PEM_read_bio_PrivateKey/ : /bad decrypt/;

// Missing passphrase
assert.throws(function() {
Expand Down Expand Up @@ -254,7 +254,8 @@ assert.throws(function() {
});
}, errMessagePassword);

const errMessageDecrypt = /bad decrypt/;
const errMessageDecrypt = common.hasOpenSSL3 ?
/Error: PEM_read_bio_PrivateKey/ : /bad decrypt/;

// Invalid passphrase
assert.throws(function() {
Expand Down