-
-
Couldn't load subscription status.
- Fork 33.6k
child_process: refactor to use more primordials #36269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
085d730 to
d1e3196
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR. Please remove the unrelated changes, and I've also let a comment on an optimisation we can make.
d1e3196 to
95ece51
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
The benchmark suite is crashing before completion, I've opened #36295 to fix that. |
|
Benchmark results: |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Landed in a897a25...f7dd330 |
PR-URL: #36269 Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #36269 Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: nodejs#36269 Reviewed-By: Antoine du Hamel <[email protected]>
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes