Skip to content

Conversation

muzhaqi16
Copy link

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Oct 21, 2020
@codecov-io
Copy link

Codecov Report

Merging #35726 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #35726   +/-   ##
=======================================
  Coverage   96.40%   96.40%           
=======================================
  Files         223      223           
  Lines       73685    73685           
=======================================
  Hits        71035    71035           
  Misses       2650     2650           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2ceb15...c17994d. Read the comment docs.

@Trott
Copy link
Member

Trott commented Oct 21, 2020

Welcome @muzhaqi16, and thanks for the pull request.

require('fs/promises') and require('fs').promises are equivalent. I'm going to close this, but if you think the change should be made, please explain in a comment and we can reopen it.

@Trott Trott closed this Oct 21, 2020
@muzhaqi16
Copy link
Author

I thought it was the same thing as well but unfortunately when I use require('fs/promises') I do receive an error message on my node environment but not if I use the second option.

Error: Cannot find module 'fs/promises'
Require stack:

My node version is v12.18.3

@muzhaqi16 muzhaqi16 mentioned this pull request Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants