Skip to content

tools: update ESLint to 7.11.0 #35578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

tools: update ESLint to 7.11.0 #35578

wants to merge 1 commit into from

Conversation

@cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Oct 9, 2020

Update ESLint to 7.11.0

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@cjihrig
tools: update ESLint to 7.11.0
9d58c9d 
Update ESLint to 7.11.0
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 9, 2020
Trott
Trott approved these changes Oct 10, 2020
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

@cjihrig cjihrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 10, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 10, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 10, 2020 •
edited by cjihrig
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/33523/ 💚

@cjihrig cjihrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 11, 2020
trivikr
trivikr approved these changes Oct 11, 2020
View reviewed changes
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@cjihrig cjihrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 11, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 11, 2020
@github-actions
Copy link
Contributor

Landed in 2e4930b...2d83e74

@github-actions github-actions bot closed this Oct 11, 2020
nodejs-github-bot pushed a commit that referenced this pull request Oct 11, 2020
@cjihrig @nodejs-github-bot
tools: update ESLint to 7.11.0
2d83e74 
Update ESLint to 7.11.0

PR-URL: #35578
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@cjihrig cjihrig deleted the eslint branch October 11, 2020 23:42
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@cjihrig @joesepi
tools: update ESLint to 7.11.0
b7813f9 
Update ESLint to 7.11.0

PR-URL: nodejs#35578
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos added dont-land-on-v14.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-requested-v14.x labels Apr 30, 2021
targos pushed a commit that referenced this pull request May 16, 2021
@cjihrig @targos
tools: update ESLint to 7.11.0
64c5f62 
Update ESLint to 7.11.0

PR-URL: #35578
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@cjihrig @targos
tools: update ESLint to 7.11.0
dcbd447 
Update ESLint to 7.11.0

PR-URL: #35578
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@Dmarch28 Dmarch28 mentioned this pull request May 10, 2022
Open
@snyk-bot snyk-bot mentioned this pull request May 10, 2022
Open
@137717unity 137717unity mentioned this pull request May 10, 2022
Open
@baby636 baby636 mentioned this pull request May 10, 2022
Open
@kissofire kissofire mentioned this pull request May 10, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request May 10, 2022
Open
@ron-a20 ron-a20 mentioned this pull request May 10, 2022
Open
@molllyn1 molllyn1 mentioned this pull request May 11, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 25, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 26, 2022
Open
@137717unity 137717unity mentioned this pull request Sep 26, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 27, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 29, 2022
Open
This was referenced Sep 29, 2022
Open
Open
This was referenced Oct 5, 2022
Open
Open
@snyk-bot snyk-bot mentioned this pull request Oct 6, 2022
Open
@137717unity 137717unity mentioned this pull request Oct 7, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Oct 7, 2022
Open
This was referenced Oct 8, 2022
Open
Open
@137717unity 137717unity mentioned this pull request Oct 9, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 9, 2022
Open
@kissofire kissofire mentioned this pull request Oct 25, 2022
Open
@molllyn1 molllyn1 mentioned this pull request Oct 26, 2022
Open
@baby636 baby636 mentioned this pull request Oct 26, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 26, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Oct 26, 2022
Open
This was referenced Oct 26, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@trivikr trivikr trivikr approved these changes

Assignees

No one assigned

Labels

tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@cjihrig @nodejs-github-bot @Trott @lpinca @trivikr @MylesBorins @targos