tools: fix Raspbian armv7 build #31041
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Dec 20, 2019
lpinca
approved these changes
Dec 20, 2019
Trott
approved these changes
Dec 21, 2019
cjihrig
approved these changes
Dec 21, 2019
Trott
added
the
author ready
|
@nodejs/build @nodejs/build-files @nodejs/gyp @nodejs/platform-arm |
|
@AHgPuK what version of Raspbian are you having trouble with and what hardware are you running? Can you give us some error output that demonstrates the need for this change? Our various ARM builds have not had a problem with this but we do a lot of cross compiling now so we could be missing something—it would be good to understand what that might be. |
|
also compiler version would be nice too |
|
yeah, ok, we're neither testing Buster, nor GCC 8 yet, so I suppose there's something in this combination that we're not getting. |
BridgeAR
pushed a commit
that referenced
this pull request
Dec 25, 2019
PR-URL: #31041 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Landed in 1bc7a50 🎉 |
BridgeAR
pushed a commit
that referenced
this pull request
Jan 3, 2020
PR-URL: #31041 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
PR-URL: #31041 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
PR-URL: #31041 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes