Skip to content

lib: replace Symbol.toPrimitive to SymbolToPrimitive primordials #30905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

lib: replace Symbol.toPrimitive to SymbolToPrimitive primordials #30905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/buffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ const {
ObjectDefineProperty,
ObjectSetPrototypeOf,
Symbol,
SymbolToPrimitive,
} = primordials;

const {
Expand Down Expand Up @@ -297,8 +298,8 @@ Buffer.from = function from(value, encodingOrOffset, length) {
if (b)
return b;

if (typeof value[Symbol.toPrimitive] === 'function') {
return Buffer.from(value[Symbol.toPrimitive]('string'),
if (typeof value[SymbolToPrimitive] === 'function') {
return Buffer.from(value[SymbolToPrimitive]('string'),
encodingOrOffset,
length);
}
Expand Down
24 changes: 12 additions & 12 deletions lib/os.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

const {
ObjectDefineProperties,
Symbol,
SymbolToPrimitive,
} = primordials;

const { safeGetenv } = internalBinding('credentials');
Expand Down Expand Up @@ -73,13 +73,13 @@ const getInterfaceAddresses = getCheckedFunction(_getInterfaceAddresses);
const getOSRelease = getCheckedFunction(_getOSRelease);
const getOSType = getCheckedFunction(_getOSType);

getFreeMem[Symbol.toPrimitive] = () => getFreeMem();
getHostname[Symbol.toPrimitive] = () => getHostname();
getHomeDirectory[Symbol.toPrimitive] = () => getHomeDirectory();
getOSRelease[Symbol.toPrimitive] = () => getOSRelease();
getOSType[Symbol.toPrimitive] = () => getOSType();
getTotalMem[Symbol.toPrimitive] = () => getTotalMem();
getUptime[Symbol.toPrimitive] = () => getUptime();
getFreeMem[SymbolToPrimitive] = () => getFreeMem();
getHostname[SymbolToPrimitive] = () => getHostname();
getHomeDirectory[SymbolToPrimitive] = () => getHomeDirectory();
getOSRelease[SymbolToPrimitive] = () => getOSRelease();
getOSType[SymbolToPrimitive] = () => getOSType();
getTotalMem[SymbolToPrimitive] = () => getTotalMem();
getUptime[SymbolToPrimitive] = () => getUptime();

const kEndianness = isBigEndian ? 'BE' : 'LE';

Expand Down Expand Up @@ -117,12 +117,12 @@ function cpus() {
function arch() {
return process.arch;
}
arch[Symbol.toPrimitive] = () => process.arch;
arch[SymbolToPrimitive] = () => process.arch;

function platform() {
return process.platform;
}
platform[Symbol.toPrimitive] = () => process.platform;
platform[SymbolToPrimitive] = () => process.platform;

function tmpdir() {
var path;
Expand All @@ -143,12 +143,12 @@ function tmpdir() {

return path;
}
tmpdir[Symbol.toPrimitive] = () => tmpdir();
tmpdir[SymbolToPrimitive] = () => tmpdir();

function endianness() {
return kEndianness;
}
endianness[Symbol.toPrimitive] = () => kEndianness;
endianness[SymbolToPrimitive] = () => kEndianness;

// Returns the number of ones in the binary representation of the decimal
// number.
Expand Down