lib: handle ENFILE error from fs.rmdir() #30499
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
fs
addaleax
approved these changes
Nov 16, 2019
cjihrig
approved these changes
Nov 18, 2019
Fishrock123
approved these changes
Nov 19, 2019
addaleax
added
the
author ready
4 tasks
jasnell
approved these changes
Nov 27, 2019
lundibundi
approved these changes
Nov 27, 2019
|
@addaleax #30644 is ready to land. I'd like to either land this first (the commit will disappear with the changes in #30644) or update the last commit in #30644 to add @thangktran as a Co-Author. Thoughts? |
cjihrig
added a commit
to cjihrig/node
that referenced
this pull request
Nov 27, 2019
Co-authored-by: Thang Tran <[email protected]> Fixes: nodejs#30482 Refs: nodejs#30499 Refs: nodejs#30580 PR-URL: nodejs#30644 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
OK. I'm going to do that. @thangktran sorry that this PR sat for a while. I've incorporated your changes in 74f8196 and added you as a Co-Author. Thanks for the contribution! |
addaleax
pushed a commit
that referenced
this pull request
Nov 30, 2019
Co-authored-by: Thang Tran <[email protected]> Fixes: #30482 Refs: #30499 Refs: #30580 PR-URL: #30644 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jan 13, 2020
Co-authored-by: Thang Tran <[email protected]> Fixes: #30482 Refs: #30499 Refs: #30580 PR-URL: #30644 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
Co-authored-by: Thang Tran <[email protected]> Fixes: #30482 Refs: #30499 Refs: #30580 PR-URL: #30644 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #30482
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes