deps: enable unit data in small-icu

[targos]

The data are needed for new Intl.NumberFormat options added by V8.

Fixes: #29734

$ ./node                                                                                                                                          
Welcome to Node.js v13.0.0-pre.
Type ".help" for more information.
> new Intl.DateTimeFormat('es', {month: 'long'}).format(new Date(9E8));
'January'
> Intl.NumberFormat('en', {style: 'unit', unit: 'meter-per-second', notation: 'scientific'}).format(299792458)
'2.998E8 m/s'

@nodejs/intl

[richardlau]

Is it worth adding a regression test?

[srl295]

LGTM with caveats:

• this PR does not refresh/regen the canned data so it will still fail.
• however, the data would get updated normally with the 65.1 bump #29540
• however, 'small icu' itself is no longer the default with #29522

so a unit test in this pr as is will not pass. But it may be worth putting this PR in (with no test until later) so that next time small icu data is updated, or manually built post-#29522 (because it will remain an option), units are included.

[srl295]

@richardlau i would make a regression test a future item, see commenet aboveee.

[targos]

@srl295 I'd be happy to refresh the data if you tell me how to do it! I already executed python tools/icu/shrink-icu-src.py to update deps/icu-small/source/data/in/icudt64l.dat

[srl295]

@srl295 I'd be happy to refresh the data if you tell me how to do it! I already executed python tools/icu/shrink-icu-src.py to update deps/icu-small/source/data/in/icudt64l.dat

OK, too quick on the review… i didn't notice the binary file (of course there's nothing per se to review in the UI). Sounds like you did it the right way.

However, as I noted, both #29540 and #29522 will obviate the change in the repo. I'm hoping to land #29522 soon.

… BUT, this does affect (i'm assuming) shipping v12. It's "only" a 3mb data file churn. So maybe it's fine to go ahead and land this in master so that it can be backported to v12

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/25766/

[Trott]

Landed in 634a9a9