Skip to content

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 17, 2019

A new version of remark-preset-lint-node adds linting for unordered list
style.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added i18n-api Issues and PRs related to the i18n implementation. tools Issues and PRs related to the tools directory. labels Sep 17, 2019
@Trott
Copy link
Member Author

Trott commented Sep 17, 2019

@Trott
Copy link
Member Author

Trott commented Sep 17, 2019

I'd like to fast-track this so that other stuff doesn't land in the interim that will violate the new lint rule. /ping @nodejs/linting for reviews and for 👍 here to approve fast-tracking request.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 17, 2019
@Trott Trott added fast-track PRs that do not need to wait for 48 hours to land. and removed i18n-api Issues and PRs related to the i18n implementation. labels Sep 18, 2019
Trott added a commit that referenced this pull request Sep 18, 2019
To confirm with upcoming markdown lint rule, use `*` for unordered
lists.

PR-URL: #29594
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Trott added a commit that referenced this pull request Sep 18, 2019
A new version of remark-preset-lint-node adds linting for unordered list
style.

PR-URL: #29594
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@Trott
Copy link
Member Author

Trott commented Sep 18, 2019

Landed in 0a0b2b7...a0c6cf8

@Trott Trott closed this Sep 18, 2019
targos pushed a commit that referenced this pull request Sep 20, 2019
To confirm with upcoming markdown lint rule, use `*` for unordered
lists.

PR-URL: #29594
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Sep 20, 2019
A new version of remark-preset-lint-node adds linting for unordered list
style.

PR-URL: #29594
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Sep 24, 2019
BridgeAR pushed a commit that referenced this pull request Sep 25, 2019
To confirm with upcoming markdown lint rule, use `*` for unordered
lists.

PR-URL: #29594
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
A new version of remark-preset-lint-node adds linting for unordered list
style.

PR-URL: #29594
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
@Trott Trott deleted the update-md-lint branch January 13, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants