Skip to content

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented Sep 13, 2019

refs: nodejs/TSC#746

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 13, 2019
@mhdawson mhdawson mentioned this pull request Sep 13, 2019
3 tasks
@mhdawson
Copy link
Member Author

@mhdawson
Copy link
Member Author

@mhdawson mhdawson added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 13, 2019
@mhdawson
Copy link
Member Author

Added fast track please upvote.

mhdawson added a commit that referenced this pull request Sep 13, 2019
refs: nodejs/TSC#746

PR-URL: #29545
Refs: nodejs/TSC#746
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@mhdawson
Copy link
Member Author

mhdawson commented Sep 13, 2019

Landed in 7c21136

@mhdawson mhdawson closed this Sep 13, 2019
targos pushed a commit that referenced this pull request Sep 20, 2019
refs: nodejs/TSC#746

PR-URL: #29545
Refs: nodejs/TSC#746
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Sep 24, 2019
BridgeAR pushed a commit that referenced this pull request Sep 25, 2019
refs: nodejs/TSC#746

PR-URL: #29545
Refs: nodejs/TSC#746
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@mhdawson mhdawson deleted the addTobias branch September 14, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants