Skip to content

util: improve debuglog performance #28956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mscdex merged 1 commit into from
Aug 9, 2019
Merged

util: improve debuglog performance #28956

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions lib/internal/util/debuglog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ function emitWarningIfNeeded(set) {

function debuglogImpl(set) {
set = set.toUpperCase();
if (!debugs[set]) {
if (debugs[set] === undefined) {
if (debugEnvRegex.test(set)) {
const pid = process.pid;
emitWarningIfNeeded(set);
Expand All @@ -42,7 +42,7 @@ function debuglogImpl(set) {
process.stderr.write(format('%s %d: %s\n', set, pid, msg));
};
} else {
debugs[set] = function debug() {};
debugs[set] = null;
}
}
return debugs[set];
Expand All @@ -55,12 +55,13 @@ function debuglogImpl(set) {
function debuglog(set) {
let debug;
return function(...args) {
if (!debug) {
if (debug === undefined) {
// Only invokes debuglogImpl() when the debug function is
// called for the first time.
debug = debuglogImpl(set);
}
debug(...args);
if (debug !== null)
debug(...args);
};
}

Expand Down