lib: use class ... extends in perf_hooks.js
#28495
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don’t unnecessarily set the protoype afterwards.
nodejs-github-bot
added
the
perf_hooks
4 tasks
cjihrig
approved these changes
Jul 1, 2019
targos
approved these changes
Jul 1, 2019
lpinca
approved these changes
Jul 1, 2019
This comment has been minimized.
This comment has been minimized.
Trott
approved these changes
Jul 1, 2019
gengjiawen
approved these changes
Jul 2, 2019
This comment has been minimized.
This comment has been minimized.
BridgeAR
approved these changes
Jul 4, 2019
BridgeAR
added
the
author ready
|
Landed in 33a8093 |
addaleax
added a commit
that referenced
this pull request
Jul 6, 2019
Don’t unnecessarily set the protoype afterwards. PR-URL: #28495 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 20, 2019
Don’t unnecessarily set the protoype afterwards. PR-URL: #28495 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
This was referenced Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don’t unnecessarily set the protoype afterwards.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes