doc: remove N-API version for Experimental APIs #28330
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Experimental APIs should not have an N-API version specified. Remove cases were one had been added incorrectly.
nodejs-github-bot
added
doc
cjihrig
approved these changes
Jun 20, 2019
richardlau
approved these changes
Jun 20, 2019
This was referenced Jun 20, 2019
gabrielschulhof
approved these changes
Jun 21, 2019
lpinca
approved these changes
Jun 21, 2019
jasnell
approved these changes
Jun 21, 2019
mhdawson
added
the
author ready
Trott
approved these changes
Jun 22, 2019
BridgeAR
approved these changes
Jun 22, 2019
|
Landed in 1b3eac4 |
addaleax
pushed a commit
that referenced
this pull request
Jun 25, 2019
Experimental APIs should not have an N-API version specified. Remove cases were one had been added incorrectly. PR-URL: #28330 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
Experimental APIs should not have an N-API version specified. Remove cases were one had been added incorrectly. PR-URL: #28330 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
This was referenced Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental APIs should not have an N-API version
specified. Remove cases were one had been added
incorrectly.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes