fs: use ES6 octal literals for mode #281
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/fs.js
Outdated
There was a problem hiding this comment.
Well, that's embarrassing. Thanks for catching this
Update docs, comments and code to use ES6 octal literals instead of decimal + comment.
vkurchatkin
force-pushed
the
octal-mode
branch
from
1bf8924 to
f8824d6
Compare
|
Wouldn't this require the |
|
@brendanashworth It will have whatever v8 has unflagged. Looks like literal octals are unflagged in the version we are using. https://www.chromestatus.com/features/4930171014479872 |
|
lgtm |
piscisaureus
pushed a commit
that referenced
this pull request
Jan 10, 2015
Update docs, comments and code to use ES6 octal literals instead of decimal + comment. PR-URL: #281 Reviewed-by: Bert Belder <[email protected]> Reviewed-by: Colin Ihrig <[email protected]>
|
Thanks @vkurchatkin! Landed in 7f9a6c6. |
Closed
This was referenced Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update docs, comments and code to use ES6 octal literals instead of decimal + comment.