Skip to content

Conversation

@richardlau
Copy link
Member

ANSI sequences are emulated on Windows, so use console.log() for
TTY's on Windows instead of directly writing to the filedescriptor.

Fixes: #27819

This is an alternative to #27823,
which is a full revert.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

ANSI sequences are emulated on Windows, so use `console.log()` for
TTY's on Windows instead of directly writing to the filedescriptor.

Fixes: nodejs#27819
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label May 22, 2019
@nodejs-github-bot
Copy link
Collaborator

@cjihrig
Copy link
Contributor

cjihrig commented May 22, 2019

Since the original point of this change was to avoid using console.log(), is this intended to be a temporary fix?

@addaleax
Copy link
Member

I mean … I think I’d prefer #27823 and sticking with console.log()print() is an optimization that doesn’t appear to be used in hot code, so I’d go with the variant that reduces code complexity the most…

@cjihrig
Copy link
Contributor

cjihrig commented May 22, 2019

I would prefer the revert as well, but based on #27819 (comment), it seemed like this would be revisited again anyway. If we're going to stick with the revert, then let's go that route.

@richardlau
Copy link
Member Author

Let's go with the revert then 😄.

@richardlau richardlau closed this May 22, 2019
@richardlau richardlau deleted the fix-2b24ffae22 branch May 22, 2019 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

util Issues and PRs related to the built-in util module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

node -p process.verions display issue on Windows Cmd

4 participants