Skip to content

Inspector chore #27712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gengjiawen wants to merge 2 commits into from
Closed

Inspector chore #27712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9c3aec
inspector: fix typo
gengjiawen May 15, 2019
0d2abb4
inspector: mark profile type const
gengjiawen May 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/inspector_profiler.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ void V8ProfilerConnection::V8ProfilerSessionDelegate::SendMessageToFrontend(
NewStringType::kNormal,
message.length())
.ToLocal(&message_str)) {
fprintf(stderr, "Failed to covert %s profile message\n", type);
fprintf(stderr, "Failed to convert %s profile message\n", type);
return;
}

Expand Down
6 changes: 2 additions & 4 deletions src/inspector_profiler.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ class V8CoverageConnection : public V8ProfilerConnection {
void Start() override;
void End() override;

const char* type() const override { return type_.c_str(); }
const char* type() const override { return "coverage"; }
bool ending() const override { return ending_; }

std::string GetDirectory() const override;
Expand All @@ -85,7 +85,6 @@ class V8CoverageConnection : public V8ProfilerConnection {
private:
std::unique_ptr<inspector::InspectorSession> session_;
bool ending_ = false;
std::string type_ = "coverage";
};

class V8CpuProfilerConnection : public V8ProfilerConnection {
Expand All @@ -96,7 +95,7 @@ class V8CpuProfilerConnection : public V8ProfilerConnection {
void Start() override;
void End() override;

const char* type() const override { return type_.c_str(); }
const char* type() const override { return "CPU"; }
bool ending() const override { return ending_; }

std::string GetDirectory() const override;
Expand All @@ -106,7 +105,6 @@ class V8CpuProfilerConnection : public V8ProfilerConnection {
private:
std::unique_ptr<inspector::InspectorSession> session_;
bool ending_ = false;
std::string type_ = "CPU";
};

} // namespace profiler
Expand Down