util: reconstruct constructor in more cases #27668
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot
added
the
util
BridgeAR
requested review from
addaleax and
antsmartian
and removed request for
addaleax
addaleax
approved these changes
May 14, 2019
BridgeAR
added
the
author ready
Collaborator
Trott
approved these changes
May 14, 2019
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
Bonus points if you run coverage to make sure all branches in the lib/internal/util/inspect.js changes are covered by existing/new tests.
antsmartian
approved these changes
May 15, 2019
Collaborator
Collaborator
Member
Author
I did not run the coverage but there are tests that verify that all branches are covered. I am also about to open a follow-up PR that adds more tests, so this should not be an issue. |
This makes sure the constructor is reconstructed in cases where we otherwise would not be able to detect the actual constructor anymore. That way some `util.inspect` output is improved. PR-URL: nodejs#27668 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
BridgeAR
force-pushed
the
reconstruct-constructor-inspect
branch
from
7bd3963 to
1bef82d
Compare
BridgeAR
added a commit
that referenced
this pull request
May 16, 2019
This makes sure the constructor is reconstructed in cases where we otherwise would not be able to detect the actual constructor anymore. That way some `util.inspect` output is improved. PR-URL: #27668 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
Member
Author
|
Landed in a92ad36 🎉 |
targos
pushed a commit
that referenced
this pull request
May 17, 2019
This makes sure the constructor is reconstructed in cases where we otherwise would not be able to detect the actual constructor anymore. That way some `util.inspect` output is improved. PR-URL: #27668 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure the constructor is reconstructed in cases where we
otherwise would not be able to detect the actual constructor anymore.
That way some
util.inspectoutput is improved.// cc @nodejs/util
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes