- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 33.6k
Remove the unsupported Python 2.6 from configure #27381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Closed
      
      
    
                
     Closed
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    A precursor to nodejs#25878
              
                    targos
  
              
              approved these changes
              
                  
                    Apr 24, 2019 
                  
              
              
            
            
              
                    BethGriggs
  
              
              approved these changes
              
                  
                    Apr 24, 2019 
                  
              
              
            
            
              
                    cjihrig
  
              
              approved these changes
              
                  
                    Apr 24, 2019 
                  
              
              
            
            
              
                    richardlau
  
              
              approved these changes
              
                  
                    Apr 24, 2019 
                  
              
              
            
            
              
                    BridgeAR
  
              
              approved these changes
              
                  
                    Apr 24, 2019 
                  
              
              
            
            
              
                    Trott
  
              
              approved these changes
              
                  
                    Apr 30, 2019 
                  
              
              
            
            
| Landed in 56098a9 | 
    
  Trott 
      pushed a commit
        to Trott/io.js
      that referenced
      this pull request
    
      Apr 30, 2019 
    
    
      
  
    
      
    
  
PR-URL: nodejs#27381 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]>
    
  targos 
      pushed a commit
      that referenced
      this pull request
    
      May 4, 2019 
    
    
      
  
    
      
    
  
PR-URL: #27381 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]>
      
     Merged
  
  This was referenced May 7, 2019 
      
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    author ready
  PRs that have at least one approval, no pending requests for changes, and a CI started. 
  
    build
  Issues and PRs related to build files or the CI. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
A precursor to #25878
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes