src: initialize worker's stack_base_ field #26739
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverity was complaining that this field was not initialized.
nodejs-github-bot
added
the
c++
danbev
approved these changes
Mar 21, 2019
ZYSzys
approved these changes
Mar 21, 2019
jasnell
approved these changes
Mar 21, 2019
|
Re-run of failing node-test-commit-arm-fanned (✔️) |
|
Landed in 76387c1. |
danbev
pushed a commit
that referenced
this pull request
Mar 22, 2019
Coverity was complaining that this field was not initialized. PR-URL: #26739 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Mar 22, 2019
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 27, 2019
Coverity was complaining that this field was not initialized. PR-URL: nodejs#26739 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Mar 27, 2019
Coverity was complaining that this field was not initialized. PR-URL: #26739 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coverity was complaining that this field was not initialized.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes