Skip to content

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 11, 2019

Edit the "Technical How-To" section of the Collaborator Guide. Keep
wording simple and direct.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 11, 2019
@richardlau
Copy link
Member

section is mispelled in the commit message.

Edit the "Technical How-To" section of the Collaborator Guide. Keep
wording simple and direct.
@Trott
Copy link
Member Author

Trott commented Mar 12, 2019

Typo in commit message fixed.

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2876/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 12, 2019
@Trott
Copy link
Member Author

Trott commented Mar 12, 2019

@vsemozhetbyt vsemozhetbyt added the meta Issues and PRs related to the general management of the project. label Mar 12, 2019
Trott added a commit to Trott/io.js that referenced this pull request Mar 14, 2019
Edit the "Technical How-To" section of the Collaborator Guide. Keep
wording simple and direct.

PR-URL: nodejs#26601
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
@Trott
Copy link
Member Author

Trott commented Mar 14, 2019

Landed in 107c95d

@Trott Trott closed this Mar 14, 2019
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
Edit the "Technical How-To" section of the Collaborator Guide. Keep
wording simple and direct.

PR-URL: nodejs#26601
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
targos pushed a commit that referenced this pull request Mar 27, 2019
Edit the "Technical How-To" section of the Collaborator Guide. Keep
wording simple and direct.

PR-URL: #26601
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 16, 2019
Edit the "Technical How-To" section of the Collaborator Guide. Keep
wording simple and direct.

PR-URL: #26601
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
@Trott Trott deleted the edit-how-to branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants