Skip to content

repl: small improvements #26496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

repl: small improvements #26496

wants to merge 4 commits into from

Conversation

gengjiawen
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the repl Issues and PRs related to the REPL subsystem. label Mar 7, 2019
mscdex
mscdex reviewed Mar 7, 2019
View reviewed changes
@BridgeAR BridgeAR changed the title small improve for repl repl: small improvements Mar 8, 2019
@BridgeAR
Copy link
Member

BridgeAR commented Mar 8, 2019

CI https://ci.nodejs.org/job/node-test-pull-request/21328/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 8, 2019
@gengjiawen gengjiawen mentioned this pull request Mar 12, 2019
Closed
2 tasks
@danbev
Copy link
Contributor

danbev commented Mar 12, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21462/

@BridgeAR
Copy link
Member

BridgeAR commented Mar 12, 2019 •
edited
Loading

Resumed CI https://ci.nodejs.org/job/node-test-pull-request/21475/ ✔️

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 13, 2019
@gengjiawen @BridgeAR
repl: remove redundant escape
a26e9a8 
PR-URL: nodejs#26496
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 13, 2019
@gengjiawen @BridgeAR
repl: simplify regex expression
2c1a8c8 
PR-URL: nodejs#26496
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 13, 2019
@gengjiawen @BridgeAR
repl: eliminate var in function _memory
024842f 
PR-URL: nodejs#26496
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@BridgeAR
Copy link
Member

Landed in b7568e1...024842f 🎉

@BridgeAR BridgeAR closed this Mar 13, 2019
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@gengjiawen @BridgeAR
repl: remove redundant escape
16e4ad7 
PR-URL: #26496
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@gengjiawen @BridgeAR
repl: simplify regex expression
f45d47f 
PR-URL: #26496
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@gengjiawen @BridgeAR
repl: eliminate var in function _memory
0ee3123 
PR-URL: #26496
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Mar 14, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 14, 2019
@gengjiawen @BridgeAR
repl: remove redundant escape
36ad91e 
PR-URL: nodejs#26496
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 14, 2019
@gengjiawen @BridgeAR
repl: simplify regex expression
e711cb3 
PR-URL: nodejs#26496
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 14, 2019
@gengjiawen @BridgeAR
repl: eliminate var in function _memory
cf41bd6 
PR-URL: nodejs#26496
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@gengjiawen @BridgeAR
repl: remove redundant escape
2101371 
PR-URL: #26496
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@gengjiawen @BridgeAR
repl: simplify regex expression
788c57b 
PR-URL: #26496
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@gengjiawen @BridgeAR
repl: eliminate var in function _memory
1a0004d 
PR-URL: #26496
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 16, 2019
@gengjiawen @BethGriggs
repl: remove redundant escape
1080a1a 
PR-URL: #26496
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 16, 2019
@gengjiawen @BethGriggs
repl: simplify regex expression
600929d 
PR-URL: #26496
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 16, 2019
@gengjiawen @BethGriggs
repl: eliminate var in function _memory
ef767a2 
PR-URL: #26496
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@targos targos targos approved these changes

@tniessen tniessen tniessen approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

+2 more reviewers

@mscdex mscdex mscdex left review comments

@antsmartian antsmartian antsmartian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. repl Issues and PRs related to the REPL subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@gengjiawen @BridgeAR @danbev @mscdex @jasnell @antsmartian @targos @tniessen @nodejs-github-bot