Skip to content

src: fix if indent in node_http2.cc #26396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

src: fix if indent in node_http2.cc #26396

wants to merge 1 commit into from
+3 −2

Conversation

gengjiawen
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v6.x http2 Issues or PRs related to the http2 subsystem. labels Mar 2, 2019
@shisama
Copy link
Contributor

shisama commented Mar 2, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21136/

@shisama
Copy link
Contributor

shisama commented Mar 3, 2019

Resume Build: https://ci.nodejs.org/job/node-test-pull-request/21157/

@shisama shisama added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 3, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 5, 2019
@gengjiawen @BridgeAR
src: fix if indent in node_http2.cc
4b84152 
PR-URL: nodejs#26396
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR
Copy link
Member

BridgeAR commented Mar 5, 2019

Landed in 4b84152 🎉

@BridgeAR BridgeAR closed this Mar 5, 2019
@gengjiawen gengjiawen deleted the if_indent branch March 5, 2019 01:01
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
@gengjiawen @BridgeAR
src: fix if indent in node_http2.cc
f99349d 
PR-URL: nodejs#26396
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Mar 13, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 16, 2019
@gengjiawen @BethGriggs
src: fix if indent in node_http2.cc
e418b4f 
PR-URL: #26396
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

+1 more reviewer

@shisama shisama shisama approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@gengjiawen @shisama @BridgeAR @jasnell @cjihrig @richardlau @nodejs-github-bot