docs: revise Collaborator Guide on reverting #25942
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revise the "Reverting commits" section of the Collaborator Guide. Reduce passive voice. Increase clarity.
jasnell
approved these changes
Feb 5, 2019
Trott
added
the
author ready
lpinca
approved these changes
Feb 5, 2019
vsemozhetbyt
approved these changes
Feb 5, 2019
vsemozhetbyt
added
the
meta
|
Landed in cf43846 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Feb 7, 2019
Revise the "Reverting commits" section of the Collaborator Guide. Reduce passive voice. Increase clarity. PR-URL: nodejs#25942 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Feb 7, 2019
Revise the "Reverting commits" section of the Collaborator Guide. Reduce passive voice. Increase clarity. PR-URL: #25942 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
Merged
This was referenced Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revise the "Reverting commits" section of the Collaborator Guide. Reduce
passive voice. Increase clarity.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes