doc: revise style guide #25778
Closed
doc: revise style guide #25778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use italics for words-as-words within style guide. Other minor improvements.
vsemozhetbyt
approved these changes
Jan 28, 2019
cjihrig
approved these changes
Jan 29, 2019
vsemozhetbyt
added
the
author ready
jasnell
approved these changes
Jan 29, 2019
|
Landed in d34671a |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 31, 2019
Use italics for words-as-words within style guide. Other minor improvements. PR-URL: nodejs#25778 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Feb 1, 2019
Use italics for words-as-words within style guide. Other minor improvements. PR-URL: #25778 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
This was referenced Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use italics for words-as-words within style guide. Other minor
improvements.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes