Skip to content

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Jan 21, 2019

follow up from d1dee49, adding @thefourtheye's documentation request.

Checklist

@bcoe bcoe added doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. labels Jan 21, 2019
@bcoe bcoe requested review from refack and thefourtheye January 21, 2019 20:34
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Jan 21, 2019
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcoe
Copy link
Contributor Author

bcoe commented Jan 22, 2019

@vsemozhetbyt added the additional ticks, also noticed the paragraph below was a bit redundant and reworded.

If folks are alright with this pass at the documentation, I'm advocating this doc change is probably okay to fast track.

@bcoe bcoe force-pushed the run-isolated-suites branch from a577e27 to f598618 Compare January 22, 2019 20:15
@bcoe
Copy link
Contributor Author

bcoe commented Jan 22, 2019

@bcoe
Copy link
Contributor Author

bcoe commented Jan 23, 2019

Landed in 885b3bc

@bcoe bcoe closed this Jan 23, 2019
@bcoe bcoe deleted the run-isolated-suites branch January 23, 2019 01:23
bcoe added a commit to bcoe/node-1 that referenced this pull request Jan 23, 2019
PR-URL: nodejs#25622
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@bcoe
Copy link
Contributor Author

bcoe commented Jan 23, 2019

Landed in e3f917e

addaleax pushed a commit that referenced this pull request Jan 23, 2019
PR-URL: #25622
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants