[10.x] vm: add dynamic import support

[joyeecheung]

PR-URL: #22381
Reviewed-By: James M Snell [email protected]
Reviewed-By: Guy Bedford [email protected]
Reviewed-By: Tiancheng "Timothy" Gu [email protected]

[nodejs-github-bot]

@joyeecheung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2210/pipeline

[joyeecheung]

cc @devsnek

[joyeecheung]

CI: https://ci.nodejs.org/job/node-test-pull-request/20033/

[joyeecheung]

cc @targos I believe this is semver-minor?

[guybedford]

I would suggest holding off on this while #25424 remains a concern.

[joyeecheung]

@guybedford I am fine with that, but be aware this unblocks clean cherry-pick of other refactoring patches to the bootstrap process

[guybedford]

@joyeecheung I understand. As it is an experimental API we could go ahead with the merge despite the bug if it would help follow-on PR work, we just need to continue to note that the importModuleDynamically API on vm.Script should be considered experimental, with known bugs, and that it may well change.

[guybedford]

Personally I think we should change the API to tie the dynamic import callback to the context.

[guybedford]

@joyeecheung assuming #21573 lands now, we should probably stick with backporting this to continue to enable backports despite the experimental woes mentioned.

[BethGriggs]

Landed on v10.x-staging in 134d1e9