test: prepare test-whatwg-encoding-* to be ported to WPT if possible #25155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split test-whatwg-encoding-textdecoder.js into: - `test-whatwg-encoding-custom-textdecoder.js` which tests Node.js-specific behaviors - `test-whatwg-encoding-custom-textdecoder-api-invalid-label.js` which is a customized version of the WPT counterpart - `test-whatwg-encoding-custom-api-basics.js` which is the part of `test-whatwg-encoding-api-basics.js` that can be run without ICU - `test-whatwg-encoding-api-basics.js` which can be replaced with WPT later.
Split `test-whatwg-encoding-textdecoder-fatal.js` into - `test-whatwg-encoding-custom-textdecoder-fatal.js` which is a customized version of the WPT that tests for Node.js-specific error codes. - `test-whatwg-encoding-custom-textdecoder-invalid-arg` which tests `ERR_INVALID_ARG_TYPE`
Split the following tests: - `test-whatwg-encoding-textdecoder-utf16-surrogates.js` - `test-whatwg-encoding-textdecoder-ignorebom.js` - `test-whatwg-encoding-textdecoder-streaming.js` Each into two files: one that can be run without ICU and one that has to be run with ICU. The latter can be replaced with WPT later.
|
cc @jasnell @TimothyGu @nodejs/testing |
jasnell
approved these changes
Dec 21, 2018
|
CI before landing https://ci.nodejs.org/job/node-test-pull-request/19850/ |
joyeecheung
added
the
author ready
|
Landed in 8a60be4...71a380b |
joyeecheung
added a commit
that referenced
this pull request
Dec 29, 2018
Split test-whatwg-encoding-textdecoder.js into: - `test-whatwg-encoding-custom-textdecoder.js` which tests Node.js-specific behaviors - `test-whatwg-encoding-custom-textdecoder-api-invalid-label.js` which is a customized version of the WPT counterpart - `test-whatwg-encoding-custom-api-basics.js` which is the part of `test-whatwg-encoding-api-basics.js` that can be run without ICU - `test-whatwg-encoding-api-basics.js` which can be replaced with WPT later. PR-URL: #25155 Reviewed-By: James M Snell <[email protected]>
joyeecheung
added a commit
that referenced
this pull request
Dec 29, 2018
Split `test-whatwg-encoding-textdecoder-fatal.js` into - `test-whatwg-encoding-custom-textdecoder-fatal.js` which is a customized version of the WPT that tests for Node.js-specific error codes. - `test-whatwg-encoding-custom-textdecoder-invalid-arg` which tests `ERR_INVALID_ARG_TYPE` PR-URL: #25155 Reviewed-By: James M Snell <[email protected]>
joyeecheung
added a commit
that referenced
this pull request
Dec 29, 2018
Split the following tests: - `test-whatwg-encoding-textdecoder-utf16-surrogates.js` - `test-whatwg-encoding-textdecoder-ignorebom.js` - `test-whatwg-encoding-textdecoder-streaming.js` Each into two files: one that can be run without ICU and one that has to be run with ICU. The latter can be replaced with WPT later. PR-URL: #25155 Reviewed-By: James M Snell <[email protected]>
joyeecheung
added a commit
that referenced
this pull request
Dec 29, 2018
PR-URL: #25155 Reviewed-By: James M Snell <[email protected]>
joyeecheung
added a commit
that referenced
this pull request
Dec 29, 2018
PR-URL: #25155 Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jan 1, 2019
Split test-whatwg-encoding-textdecoder.js into: - `test-whatwg-encoding-custom-textdecoder.js` which tests Node.js-specific behaviors - `test-whatwg-encoding-custom-textdecoder-api-invalid-label.js` which is a customized version of the WPT counterpart - `test-whatwg-encoding-custom-api-basics.js` which is the part of `test-whatwg-encoding-api-basics.js` that can be run without ICU - `test-whatwg-encoding-api-basics.js` which can be replaced with WPT later. PR-URL: #25155 Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jan 1, 2019
Split `test-whatwg-encoding-textdecoder-fatal.js` into - `test-whatwg-encoding-custom-textdecoder-fatal.js` which is a customized version of the WPT that tests for Node.js-specific error codes. - `test-whatwg-encoding-custom-textdecoder-invalid-arg` which tests `ERR_INVALID_ARG_TYPE` PR-URL: #25155 Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jan 1, 2019
Split the following tests: - `test-whatwg-encoding-textdecoder-utf16-surrogates.js` - `test-whatwg-encoding-textdecoder-ignorebom.js` - `test-whatwg-encoding-textdecoder-streaming.js` Each into two files: one that can be run without ICU and one that has to be run with ICU. The latter can be replaced with WPT later. PR-URL: #25155 Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jan 1, 2019
PR-URL: #25155 Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jan 1, 2019
PR-URL: #25155 Reviewed-By: James M Snell <[email protected]>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Split test-whatwg-encoding-textdecoder.js into: - `test-whatwg-encoding-custom-textdecoder.js` which tests Node.js-specific behaviors - `test-whatwg-encoding-custom-textdecoder-api-invalid-label.js` which is a customized version of the WPT counterpart - `test-whatwg-encoding-custom-api-basics.js` which is the part of `test-whatwg-encoding-api-basics.js` that can be run without ICU - `test-whatwg-encoding-api-basics.js` which can be replaced with WPT later. PR-URL: nodejs#25155 Reviewed-By: James M Snell <[email protected]>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Split `test-whatwg-encoding-textdecoder-fatal.js` into - `test-whatwg-encoding-custom-textdecoder-fatal.js` which is a customized version of the WPT that tests for Node.js-specific error codes. - `test-whatwg-encoding-custom-textdecoder-invalid-arg` which tests `ERR_INVALID_ARG_TYPE` PR-URL: nodejs#25155 Reviewed-By: James M Snell <[email protected]>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Split the following tests: - `test-whatwg-encoding-textdecoder-utf16-surrogates.js` - `test-whatwg-encoding-textdecoder-ignorebom.js` - `test-whatwg-encoding-textdecoder-streaming.js` Each into two files: one that can be run without ICU and one that has to be run with ICU. The latter can be replaced with WPT later. PR-URL: nodejs#25155 Reviewed-By: James M Snell <[email protected]>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#25155 Reviewed-By: James M Snell <[email protected]>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#25155 Reviewed-By: James M Snell <[email protected]>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: split test-whatwg-encoding-textdecoder.js
Split
test-whatwg-encoding-textdecoder.jsinto:test-whatwg-encoding-custom-textdecoder.jswhich testsNode.js-specific behaviors
test-whatwg-encoding-custom-textdecoder-api-invalid-label.jswhich isa customized version of the WPT counterpart
test-whatwg-encoding-custom-api-basics.jswhich is the part oftest-whatwg-encoding-api-basics.jsthat can be run without ICUtest-whatwg-encoding-api-basics.jswhich can be replaced with WPTlater.
test: split test-whatwg-encoding-textdecoder-fatal.js
Split
test-whatwg-encoding-textdecoder-fatal.jsintotest-whatwg-encoding-custom-textdecoder-fatal.jswhichis a customized version of the WPT that tests for Node.js-specific
error codes.
test-whatwg-encoding-custom-textdecoder-invalid-argwhichtests
ERR_INVALID_ARG_TYPEtest: split encoding tests where some cases can be run without ICU
test: rename custom encoding tests that cannot be replaced by WPT
test: add TODO to encoding tests that can be replaced with WPT
Split the following tests:
test-whatwg-encoding-textdecoder-utf16-surrogates.jstest-whatwg-encoding-textdecoder-ignorebom.jstest-whatwg-encoding-textdecoder-streaming.jsEach into two files: one that can be run without ICU and one that has
to be run with ICU. The latter can be replaced with WPT later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes