test: refactor test-esm-namespace.mjs #25117
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused `name` argument that is different from a subsequent `name` argument in a different but nearby function. This was mildly confusing to me at first, so hopefully this change clarifies things for others reading the test.
jasnell
approved these changes
Dec 19, 2018
|
Landed in ae73b73 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Dec 26, 2018
Remove unused `name` argument that is different from a subsequent `name` argument in a different but nearby function. This was mildly confusing to me at first, so hopefully this change clarifies things for others reading the test. PR-URL: nodejs#25117 Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jan 1, 2019
Remove unused `name` argument that is different from a subsequent `name` argument in a different but nearby function. This was mildly confusing to me at first, so hopefully this change clarifies things for others reading the test. PR-URL: #25117 Reviewed-By: James M Snell <[email protected]>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Remove unused `name` argument that is different from a subsequent `name` argument in a different but nearby function. This was mildly confusing to me at first, so hopefully this change clarifies things for others reading the test. PR-URL: nodejs#25117 Reviewed-By: James M Snell <[email protected]>
Merged
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 17, 2019
Remove unused `name` argument that is different from a subsequent `name` argument in a different but nearby function. This was mildly confusing to me at first, so hopefully this change clarifies things for others reading the test. PR-URL: #25117 Reviewed-By: James M Snell <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 28, 2019
Remove unused `name` argument that is different from a subsequent `name` argument in a different but nearby function. This was mildly confusing to me at first, so hopefully this change clarifies things for others reading the test. PR-URL: #25117 Reviewed-By: James M Snell <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
May 10, 2019
Remove unused `name` argument that is different from a subsequent `name` argument in a different but nearby function. This was mildly confusing to me at first, so hopefully this change clarifies things for others reading the test. PR-URL: #25117 Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 16, 2019
Remove unused `name` argument that is different from a subsequent `name` argument in a different but nearby function. This was mildly confusing to me at first, so hopefully this change clarifies things for others reading the test. PR-URL: #25117 Reviewed-By: James M Snell <[email protected]>
This was referenced May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused
nameargument that is different from a subsequentnameargument in a different but nearby function. This was mildly confusing
to me at first, so hopefully this change clarifies things for others
reading the test.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes