test: mark test-cli-node-options flaky on arm #25032
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
test
gireeshpunathil
approved these changes
Dec 14, 2018
cjihrig
approved these changes
Dec 14, 2018
watilde
approved these changes
Dec 14, 2018
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19519/ |
|
ARM failure was a different pair of tests that I believe is infra-related. Affected host as been taken offline. Rebuild: https://ci.nodejs.org/job/node-test-commit-arm/20816/ ✔️ Rest of CI is good, so if that passes, this can land. |
|
Landed in adf5083 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Dec 14, 2018
Refs: nodejs#25028 PR-URL: nodejs#25032 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 18, 2018
Refs: #25028 PR-URL: #25032 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
Merged
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Refs: nodejs#25028 PR-URL: nodejs#25032 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 29, 2019
Refs: #25028 PR-URL: #25032 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jan 29, 2019
Refs: #25028 PR-URL: #25032 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jan 29, 2019
Refs: #25028 PR-URL: #25032 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
This was referenced Jan 29, 2019
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
Refs: #25028 PR-URL: #25032 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collaborators, 👍 here to fast-track.
Refs: #25028
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes