doc: in order to be consistent with the previous items #25003
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
approved these changes
Dec 13, 2018
|
can i ask Why Travis CI failed |
Your commit message is malformed. First line should not have punctuation at the end and should not be longer than 72 characters (and preferably not longer than 50 but that's a soft limit). Someone will fix it while landing, but if you want to fix it for them, that's fine too.
|
|
Thank you for your reply, help me a lot ,thank you again. |
richardlau
approved these changes
Dec 13, 2018
|
Landed in 2c5dae5, thanks for the PR! 🎉 |
addaleax
pushed a commit
that referenced
this pull request
Dec 15, 2018
In order to be consistent with the previous items, I split the sentence. PR-URL: #25003 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]>
|
Thank you for helping me fix it. |
BethGriggs
pushed a commit
that referenced
this pull request
Dec 18, 2018
In order to be consistent with the previous items, I split the sentence. PR-URL: #25003 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
In order to be consistent with the previous items, I split the sentence. PR-URL: nodejs#25003 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 12, 2019
In order to be consistent with the previous items, I split the sentence. PR-URL: #25003 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Feb 20, 2019
In order to be consistent with the previous items, I split the sentence. PR-URL: #25003 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
In order to be consistent with the previous items, I split the sentence. PR-URL: #25003 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in order to be consistent with the previous items
i delete the period and split the sentence.