Skip to content

src: emit 'params' instead of 'data' for NodeTracing.dataCollected #24949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

src: emit 'params' instead of 'data' for NodeTracing.dataCollected #24949

wants to merge 1 commit into from

Conversation

kjin
Copy link
Contributor

@kjin kjin commented Dec 10, 2018 •
edited
Loading

All inspector event emissions emit an object of the shape { method: string, params: {} } except for NodeTracing.dataCollected. This PR changes this event to emit an object with a params field instead of data.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Dec 10, 2018
@addaleax addaleax added inspector Issues and PRs related to the V8 inspector protocol trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. labels Dec 11, 2018
addaleax
addaleax approved these changes Dec 11, 2018
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @nodejs/trace-events

@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/19410/

@antsmartian antsmartian added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 11, 2018
@Trott
Copy link
Member

Trott commented Dec 14, 2018

@nodejs/trace-events semver-patch?

@Trott
Copy link
Member

Trott commented Dec 14, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/19495/

@ofrobots
Copy link
Contributor

Trace events are experimental, so my vote is semver-patch.

@Trott
Copy link
Member

Trott commented Dec 14, 2018 •
edited
Loading

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19498/ ✔️

@Trott
Copy link
Member

Trott commented Dec 14, 2018

Landed in 49f1db4

@Trott Trott closed this Dec 14, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 14, 2018
@kjin @Trott
src: emit 'params' instead of 'data' for NodeTracing.dataCollected
49f1db4 
PR-URL: nodejs#24949
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 18, 2018
@kjin @BethGriggs
src: emit 'params' instead of 'data' for NodeTracing.dataCollected
5f8950b 
PR-URL: #24949
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 18, 2018
Merged
@beevelop beevelop mentioned this pull request Dec 18, 2018
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@kjin @refack
src: emit 'params' instead of 'data' for NodeTracing.dataCollected
4a14223 
PR-URL: nodejs#24949
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@kjin @BethGriggs
src: emit 'params' instead of 'data' for NodeTracing.dataCollected
944e75d 
PR-URL: #24949
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
@kjin @BethGriggs
src: emit 'params' instead of 'data' for NodeTracing.dataCollected
2f39027 
PR-URL: #24949
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: James M Snell <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@kjin @rvagg
src: emit 'params' instead of 'data' for NodeTracing.dataCollected
38724f6 
PR-URL: #24949
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

+2 more reviewers

@ofrobots ofrobots ofrobots approved these changes

@antsmartian antsmartian antsmartian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@kjin @addaleax @Trott @ofrobots @jasnell @antsmartian @cjihrig @BethGriggs @nodejs-github-bot