Skip to content

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Nov 30, 2018

pulled out of #23926

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Nov 30, 2018
@devsnek devsnek added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Nov 30, 2018
@devsnek devsnek force-pushed the refactor/native-try-catch branch from 455b2e1 to f005e34 Compare November 30, 2018 14:23
@joyeecheung
Copy link
Member

@devsnek devsnek force-pushed the refactor/native-try-catch branch from f005e34 to 39c9a18 Compare December 3, 2018 15:15
@devsnek
Copy link
Member Author

devsnek commented Dec 3, 2018

@devsnek devsnek force-pushed the refactor/native-try-catch branch from 39c9a18 to f084e06 Compare December 3, 2018 16:25
@devsnek
Copy link
Member Author

devsnek commented Dec 3, 2018

landed in f084e06

@devsnek devsnek merged commit f084e06 into nodejs:master Dec 3, 2018
@Trott
Copy link
Member

Trott commented Dec 3, 2018

This is getting-the-word-out and not a complaint/criticism, as the rule changed less than two months ago and not everyone has gotten the memo yet:

This should not have landed without a second review or waiting until it had been open 7 days. https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md#code-reviews:

At least two Collaborators must approve a pull request before the pull request lands. (One Collaborator approval is enough if the pull request has been open for more than 7 days.)

@devsnek devsnek deleted the refactor/native-try-catch branch December 3, 2018 18:47
@devsnek
Copy link
Member Author

devsnek commented Dec 3, 2018

@Trott thanks, i'll remember that in the future 👍

@joyeecheung
Copy link
Member

Should be fixed by nodejs/node-core-utils#290 (I just updated the branch), anyone wants to take a look?

screen shot 2018-12-04 at 2 48 56 am

@BethGriggs
Copy link
Member

This change does not land cleanly on v10.x-staging. I've added the backport-requested-v10.x label, but feel free to swap to dont-land-on- if this change shouldn't land on v10.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. errors Issues and PRs related to JavaScript errors originated in Node.js core. lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants