test: remove unused function arguments in async-hooks tests #24406
Conversation
nodejs-github-bot
added
async_hooks
blacksun1
changed the title
blacksun1
changed the title
refack
added
the
author ready
|
Hello @blacksun1, and thank you for the contribution🥇 P.S. But seriously, if you have any questions, feel free to contact me directly. P.P.S. I see you have two GitHub users, take a look at the headers of https://patch-diff.githubusercontent.com/raw/nodejs/node/pull/24406.patch and make sure the author attribution is to you liking. |
Shoot, I saw that the email address was wrong. I've updated the commit and repushed. I hope that this was the correct way to make sure it was set correctly. |
Looks correct now |
Remove unused function arguments in three async-hooks tests and improve test consistancy.
|
@Trott, do you want to run your CI job again? Not sure why it crashed last time |
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18733/ |
Remove unused function arguments in three async-hooks tests and improve test consistancy. PR-URL: nodejs#24406 Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 738e076. Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
Remove unused function arguments in three async-hooks tests and improve test consistancy. PR-URL: #24406 Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
Remove unused function arguments in three async-hooks tests and improve test consistancy. PR-URL: #24406 Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
Remove unused function arguments in three async-hooks tests and improve test consistancy. PR-URL: #24406 Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
Remove unused function arguments in three async-hooks tests and improve test consistancy. PR-URL: nodejs#24406 Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
Remove unused function arguments in three async-hooks tests and improve test consistancy. PR-URL: #24406 Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
6 participants
Remove unused function arguments in three async-hooks tests and improve test consistency.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes