test: add test for autoDestroy in stream #24127
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Nov 6, 2018
mafintosh
approved these changes
Nov 7, 2018
mafintosh
reviewed
Nov 7, 2018
mafintosh
reviewed
Nov 7, 2018
jasnell
approved these changes
Nov 10, 2018
PR-URL: nodejs#24127 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mathias Buus <[email protected]>
watilde
force-pushed
the
test/auto-destory
branch
from
b4918ae to
4ac6ded
Compare
|
Rebased and ci: https://ci.nodejs.org/job/node-test-pull-request/18546/ |
|
Landed in d6f52f5. Thanks. |
pull bot
pushed a commit
to SimenB/node
that referenced
this pull request
Nov 12, 2018
PR-URL: nodejs#24127 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mathias Buus <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Nov 14, 2018
PR-URL: #24127 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mathias Buus <[email protected]>
kiyomizumia
pushed a commit
to kiyomizumia/node
that referenced
this pull request
Nov 15, 2018
PR-URL: nodejs#24127 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mathias Buus <[email protected]>
This was referenced Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Apparently,
stream.destroy(err)inerrorOrDestroyis not called. Adding two test cases to cover that line.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesReferences