lib: move module exports proxy into a separate method #24057
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added the comment in f074612 to make NativeModule.prototype.compile() more readable.
addaleax
approved these changes
Nov 3, 2018
devsnek
approved these changes
Nov 3, 2018
joyeecheung
added
the
author ready
refack
approved these changes
Nov 3, 2018
|
Landed in c3b674c. |
danbev
pushed a commit
that referenced
this pull request
Nov 6, 2018
Also added the comment in f074612 to make NativeModule.prototype.compile() more readable. PR-URL: #24057 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 6, 2018
Also added the comment in f074612 to make NativeModule.prototype.compile() more readable. PR-URL: #24057 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
This was referenced Nov 15, 2018
3 tasks
codebytere
pushed a commit
that referenced
this pull request
Nov 29, 2018
Also added the comment in f074612 to make NativeModule.prototype.compile() more readable. PR-URL: #24057 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
Also added the comment in f074612 to make NativeModule.prototype.compile() more readable. PR-URL: #24057 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Dec 3, 2018
Also added the comment in f074612 to make NativeModule.prototype.compile() more readable. PR-URL: #24057 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added the comment in f074612 to make
NativeModule.prototype.compile() more readable.