Skip to content

src: remove delete MessagePort.prototype.hasRef; #23471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

src: remove delete MessagePort.prototype.hasRef; #23471

wants to merge 1 commit into from

Conversation

code-for-coffee
Copy link

Completed during Node+JS Interactive Code+Learn.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

src: remove delete MessagePort.prototype.hasRef;
74e6f68 
src: remove delete MessagePort.prototype.hasRef;

Node Code+Learn: remote delete MessagePort.prototype.hasRef;
@nodejs-github-bot nodejs-github-bot added the worker Issues and PRs related to Worker support. label Oct 12, 2018
@targos targos added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 12, 2018
@Trott Trott mentioned this pull request Oct 14, 2018
Closed
@Trott
Copy link
Member

Trott commented Oct 14, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17843/

@addaleax
Copy link
Member

Landed in b22903e

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@addaleax addaleax closed this Oct 14, 2018
addaleax pushed a commit that referenced this pull request Oct 14, 2018
@addaleax
worker: remove delete MessagePort.prototype.hasRef
b22903e 
Node Code+Learn: remove delete MessagePort.prototype.hasRef;

PR-URL: #23471
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
addaleax pushed a commit that referenced this pull request Oct 14, 2018
@addaleax
worker: remove delete MessagePort.prototype.hasRef
174732e 
Node Code+Learn: remove delete MessagePort.prototype.hasRef;

PR-URL: #23471
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@jasnell
worker: remove delete MessagePort.prototype.hasRef
7673de8 
Node Code+Learn: remove delete MessagePort.prototype.hasRef;

PR-URL: #23471
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
@MylesBorins
worker: remove delete MessagePort.prototype.hasRef
1c17aa1 
Node Code+Learn: remove delete MessagePort.prototype.hasRef;

PR-URL: #23471
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@rvagg
worker: remove delete MessagePort.prototype.hasRef
061c5dc 
Node Code+Learn: remove delete MessagePort.prototype.hasRef;

PR-URL: #23471
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@MylesBorins
worker: remove delete MessagePort.prototype.hasRef
a5dd25f 
Node Code+Learn: remove delete MessagePort.prototype.hasRef;

PR-URL: #23471
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@codebytere codebytere codebytere approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. worker Issues and PRs related to Worker support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@code-for-coffee @Trott @addaleax @jasnell @codebytere @cjihrig @targos @nodejs-github-bot