test: update test-cluster-worker-events to use arrow functions. #23469
Conversation
targos
added
the
code-and-learn
|
@AbbottEverett thanks for your PR- the change itself looks good to me but your git config needs a little tweak. Can you run the following command to set your email in your git config: Then run (thanks to @gireeshpunthil for this tip!) |
|
Thanks for the advice @digitalinfinity. I made the changes and pushed to this branch. |
| const messages = []; | ||
|
|
||
| function check(m) { | ||
| const check = (m) => { |
There was a problem hiding this comment.
Just a nit: for top level functions like this, using the function check(m) { form is preferred. The arrow functions on the event handlers is fine.
Trott
added
fast-track
|
Collaborators, please 👍 here to fast-track. |
|
Landed in 3989785. Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
PR-URL: nodejs#23469 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #23469 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #23469 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #23469 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #23469 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #23469 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]>
7 participants
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes