http: name anonymous function in _http_common.js #21755
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Jul 11, 2018
trivikr
approved these changes
Jul 11, 2018
|
Thank you @kimberlake for your first PR in Node.js core! 🎉 |
lpinca
approved these changes
Jul 12, 2018
BridgeAR
approved these changes
Jul 12, 2018
BridgeAR
added
the
author ready
maclover7
approved these changes
Jul 13, 2018
|
Looks like CI hit a bunch of flakes last time, re-running: https://ci.nodejs.org/job/node-test-pull-request/15857/ |
|
Last CI was showing unstable, started a new one at https://ci.nodejs.org/job/node-test-pull-request/15881/ |
cjihrig
approved these changes
Jul 16, 2018
trivikr
pushed a commit
that referenced
this pull request
Jul 18, 2018
Refs: #8913 PR-URL: #21755 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Landed in 72624fd Congratulations @kimberlake on your first commit in Node.js core! 🎉🎉🎉 |
targos
pushed a commit
that referenced
this pull request
Jul 19, 2018
Refs: #8913 PR-URL: #21755 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
This was referenced Aug 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #8913
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes