test: plug AliasedBuffer cctest memory leak #20665
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to heap-allocate values here.
addaleax
added
the
c++
|
Neither the linter nor cl.exe seems to like VLAs. Not a fan myself for that matter, I'd use |
|
@bnoordhuis Yup, done (but switched throughout the file, not just where the original change was). |
jasnell
approved these changes
May 10, 2018
bnoordhuis
approved these changes
May 10, 2018
cjihrig
approved these changes
May 10, 2018
danbev
approved these changes
May 11, 2018
|
Linux CI re-run: https://ci.nodejs.org/job/node-test-commit-linux/18666/ |
addaleax
added
the
author ready
jasnell
pushed a commit
that referenced
this pull request
May 12, 2018
No need to heap-allocate values here. PR-URL: #20665 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
|
Landed in 19c9ff5 |
addaleax
added a commit
that referenced
this pull request
May 14, 2018
No need to heap-allocate values here. PR-URL: #20665 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Merged
addaleax
added a commit
that referenced
this pull request
Jun 29, 2018
No need to heap-allocate values here. PR-URL: #20665 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Merged
rvagg
pushed a commit
that referenced
this pull request
Aug 16, 2018
No need to heap-allocate values here. PR-URL: #20665 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to heap-allocate values here.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes