lib: document nextTick queue internals #19469
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make this code (a bit more) comprehensible by adding some internals docs. It has diagrams and everything.
nodejs-github-bot
added
the
process
apapirovski
approved these changes
Mar 20, 2018
lib/internal/process/next_tick.js
Outdated
| // Adding a value means moving `top` forward by one, removing means | ||
| // moving `bottom` forward by one. | ||
| // | ||
| // We let `bottom` and `top` wrap around, so when `top` is conceptual.y |
lpinca
approved these changes
Mar 20, 2018
BridgeAR
approved these changes
Mar 20, 2018
starkwang
approved these changes
Mar 20, 2018
lpinca
added
the
author ready
joyeecheung
approved these changes
Mar 20, 2018
cjihrig
approved these changes
Mar 20, 2018
jasnell
approved these changes
Mar 20, 2018
jasnell
approved these changes
Mar 20, 2018
|
(yes, I approved it twice... I really like this) |
tniessen
approved these changes
Mar 20, 2018
devsnek
approved these changes
Mar 20, 2018
| } else { | ||
| // If the head is empty, that means that it was the only fixed-sized | ||
| // queue in existence. | ||
| DCHECK_EQ(head.next, null); |
|
New CI, to be sure: https://ci.nodejs.org/job/node-test-commit/17121/ |
|
Landed in 34a948f |
addaleax
added a commit
that referenced
this pull request
Mar 25, 2018
Make this code (a bit more) comprehensible by adding some internals docs. With diagrams and everything! 🎉 PR-URL: #19469 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
addaleax
removed
the
author ready
targos
pushed a commit
that referenced
this pull request
Apr 2, 2018
Make this code (a bit more) comprehensible by adding some internals docs. With diagrams and everything! 🎉 PR-URL: #19469 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make this code (a bit more) comprehensible by adding some
internals docs.
It has diagrams and everything.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesCI: https://ci.nodejs.org/job/node-test-commit/17016/