events: preset usingDomains to false
#18944
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
events
Contributor
Author
|
CI: https://ci.nodejs.org/job/node-test-pull-request/13338/ edit: relaunched CI due to linting error |
MylesBorins
added
the
fast-track
Contributor
Author
|
I'd like to fast track this and potentially get a release out this evening with this change included |
The line setting this was removed in a previous commit. This potentially breaks code in the wild using this property. Refs: nodejs#17403 (comment)
MylesBorins
force-pushed
the
events-using-domains
branch
from
aacb40a to
ddf746c
Compare
addaleax
approved these changes
Feb 22, 2018
benjamingr
approved these changes
Feb 23, 2018
Contributor
Author
|
lots of flakes + infra failures in CI, running one more time |
Contributor
Author
|
green aside from infra failures, landed in 6657b15 |
MylesBorins
added a commit
that referenced
this pull request
Feb 23, 2018
The line setting this was removed in a previous commit. This potentially breaks code in the wild using this property. Refs: #17403 (comment) PR-URL: #18944 Reviewed-By: Vladimir de Turckheim <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
MylesBorins
added a commit
that referenced
this pull request
Feb 23, 2018
The line setting this was removed in a previous commit. This potentially breaks code in the wild using this property. Refs: #17403 (comment) PR-URL: #18944 Reviewed-By: Vladimir de Turckheim <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Merged
MylesBorins
added a commit
that referenced
this pull request
Feb 23, 2018
Notable changes:
* events:
- `events.usingDomains` being set to false by default was removed in
9.6.0 which was a change in behavior compared to 9.5.0. This
behavior change has been reverted and the `events` object now has
`usingDomains` preset to `false`, which is the behavior in 9.x
prior to 9.6.0 (Myles Borins)
#18944
PR-URL: #18946
MylesBorins
added a commit
that referenced
this pull request
Feb 23, 2018
Notable changes:
* events:
- `events.usingDomains` being set to false by default was removed in
9.6.0 which was a change in behavior compared to 9.5.0. This
behavior change has been reverted and the `events` object now has
`usingDomains` preset to `false`, which is the behavior in 9.x
prior to 9.6.0 (Myles Borins)
#18944
PR-URL: #18946
4 tasks
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
The line setting this was removed in a previous commit. This potentially breaks code in the wild using this property. Refs: nodejs#17403 (comment) PR-URL: nodejs#18944 Reviewed-By: Vladimir de Turckheim <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Notable changes:
* events:
- `events.usingDomains` being set to false by default was removed in
9.6.0 which was a change in behavior compared to 9.5.0. This
behavior change has been reverted and the `events` object now has
`usingDomains` preset to `false`, which is the behavior in 9.x
prior to 9.6.0 (Myles Borins)
nodejs#18944
PR-URL: nodejs#18946
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The line setting this was removed in a previous commit. This
potentially breaks code in the wild using this property.
Refs: #17403 (comment)
Alternative to #18942